Feature specs #254
Feature specs #254
Conversation
sauloperez
force-pushed
the
feature-specs
branch
4 times, most recently
from
a712df2 to
07b4e61
Compare
This sets up capybara with the new headless chrome driver and adds the necessary requires in order to run single spec file. So far, there was no other way than doing `bundle exec rake` due to missing requires.
The headless chromedriver requires Chrome to be installed. See https://robots.thoughtbot.com/headless-feature-specs-with-chrome#on-ci for details.
sauloperez
force-pushed
the
feature-specs
branch
from
07b4e61 to
eab7185
Compare
We had `use_transactional_fixtures` enabled but no fixtures where defined in spec/fixtures. This prevented Capybara tests with javascript to work. This is explained in detail in https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example.
sauloperez
force-pushed
the
feature-specs
branch
from
17e8b26 to
0134341
Compare
| context 'with a valid password' do | ||
| it 'signs the user in' do | ||
| sign_in_with(user.email, 'papapa22') | ||
| expect(page).to have_content(I18n.t('application.navbar.sign_out')) |
There was a problem hiding this comment.
it checks that the log out link is present. That means we succesfully logged in.
There was a problem hiding this comment.
a bit misleading IMHO, maybe we should specify that in the example description or find another way to be check that the user is logged in
|
|
||
| # hack alert! there is no translation for this string. How we build the | ||
| # copy then? | ||
| click_button 'Crear Transferencia' |
There was a problem hiding this comment.
In which language are we executing feature specs? We should use only one, english IMHO.
There was a problem hiding this comment.
I haven't touched any language setting so I guess some sort of default. We'll need to check it.
| require 'capybara/rails' | ||
| require 'database_cleaner' | ||
| require 'fabrication' | ||
| require 'selenium/webdriver' |
There was a problem hiding this comment.
Do we need this for unit tests too?
There was a problem hiding this comment.
no, and capybara/rails neither but where do you want to require them? remember a bundle exec rake should work as well (it's what CI does).
There was a problem hiding this comment.
I used to create a feature_spec_helper.rb with this kind of stuff, but if I'm OK if we leave it here.
| Document.create(label: "t&c") do |doc| | ||
| doc.title = "Terms and Conditions" | ||
| doc.content = "blah blah blah" | ||
| end |
There was a problem hiding this comment.
the T&C in spec_helper are not enough?
There was a problem hiding this comment.
Yep. I fixed it with the last push and now I need to remove this.
I want to know if when the t&c could not be created because the tests assume they are always persisted in DB.
|
I give up, at least for now. Feature testing with angular it's painful and although some people succeeded it appears not to be a common approach. The main problem is that due to my lack of knowledge of angular, I can't manage to wait for it to "compile" the views. The DOM elements are still hidden when the test is executed and Capybara doesn't like that. Even forcing it to find hidden elements, I get Once we remove angular (I think it brings little to no value now) from the app we will be in a much better position. |
|
😭 |
|
Fixing provisioning issues here coopdevs/timeoverflow-provisioning#40 And adding chromedriver to devenv here I'm now investigating DatabaseCleaner strategies. Looks like it's cleaning too compulsively See screenshot from capybara here coopdevs/timeoverflow-provisioning#41
|
By the time the sign in request reaches the controller, the user is gone from DB 💥 Tried removing DatabaseCleaner and the sign in spec works ( assertion needs to be fixed )
|
🙈 we're pretty late to the capybara party so there must be some documentation to play it well with database cleaner. |
|
okiii, let's continue in #333 💃 |
3 participants
El viernes estuve trabajando en un pequeño refactor de transferencias de tiempo entre miembros y organizaciones y me vi constantemente probando las transferencias manualmente. Aunque tenemos alguno tests justamente tuve que añadir tests de controller para los actions que estoy tocando (pull request en breve).
Sin embargo, para ir más ágil pensé en automitzar el test manual de transferir y así avanzar más rápido en el refactor sin romper nada. Esto al darnos más seguridad de que las cosas no se rompen facilitará las contribuciones esporádicas y quitará algo de trabajo a @sseerrggii .
Esta PR añade las gemas necesarias para empezar a tener unos
spec/features/con los que podamos garantizar que las features esencial y críticas de la app funcionan.De momento solo añado un test para login y otro para logout. Aún tengo que averigar como hacer tests ejecutando JS.