Feature specs #333
Merged
Feature specs #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
❤ |
This sets up capybara with the new headless chrome driver and adds the necessary requires in order to run single spec file. So far, there was no other way than doing `bundle exec rake` due to missing requires.
The headless chromedriver requires Chrome to be installed. See https://robots.thoughtbot.com/headless-feature-specs-with-chrome#on-ci for details.
We had `use_transactional_fixtures` enabled but no fixtures where defined in spec/fixtures. This prevented Capybara tests with javascript to work. This is explained in detail in https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example.
I want to know if when the t&c could not be created because the tests assume they are always persisted in DB.
Morantron
force-pushed
the
feature-specs
branch
from
f9533e8 to
f129448
Compare
sauloperez
previously requested changes
Mar 16, 2018
| sign_in_with(user.email, 'papapa22') | ||
|
|
||
| expect(Capybara.current_session.driver.browser.manage.cookie_named('_timeoverflow_session')).to be_truthy | ||
| end |
There was a problem hiding this comment.
I would also expect to navigate to a page which contains the nav menu, or the terms of service
spec/features/transfer_spec.rb
Outdated
| fill_in 'transfer_minutes', with: minutes | ||
|
|
||
| # hack alert! there is no translation for this string. How we build the | ||
| # copy then? |
There was a problem hiding this comment.
I'd rather create an issue
There was a problem hiding this comment.
this is just active record magic, see here
| Document.create!(label: "t&c") do |doc| | ||
| doc.title = "Terms and Conditions" | ||
| doc.content = "blah blah blah" | ||
| end |
There was a problem hiding this comment.
What about creating a #create_terms_and_conditions?
Morantron
force-pushed
the
feature-specs
branch
2 times, most recently
from
372380b to
f9f86f5
Compare
Morantron
force-pushed
the
feature-specs
branch
from
0cfc6d1 to
90ac1d4
Compare
enricostano
approved these changes
May 10, 2018
sauloperez
reviewed
May 10, 2018
| fill_in 'offer_description', with: 'Lorem ipsum in the night' | ||
| select category.name, from: 'offer_category_id' | ||
|
|
||
| # TODO there are two i18n keys for getting "Crear oferta" copy ( one returns 'Crear oferta' and the other 'Crear Oferta' ) |
There was a problem hiding this comment.
Can we create an issue so we keep track of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting #254