Upgrade to rails 4.2.7.1 #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple known security vulnerabilities related to ActiveView and ActiveRecord.
sauloperez
force-pushed
the
upgrade-to-rails4.2.7.1
branch
from
6651497 to
2fed22d
Compare
The upgrade to 3.5 fixes the failure ruby/rake#116
|
I had to upgrade RSpec Rails as well in order to get rid of this well known failure ruby/rake#116. Basically, The RSpec rails version we were using calls a rake method that no longer exists. |
|
#273 goes a bit further and upgrades Rails to 4.2.10 among other dependencies. I suggest we merge this one first so that then #273 it's a smaller change |
enricostano
approved these changes
Jan 11, 2018
|
Tested 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve the most severe of the security vulnerabilities highlighted by GitHub. They are related to ActionView and ActiveRecord so we would be better off upgrading. You can see the full list of changes in rails/rails@v4.2.5.2...v4.2.7.1. Besides, as we all know it's a good practice to keep up to date ASAP.
The upgrade should be harmless as the changes are very limited. As soon as this passes CI, I'd give a general testing round and merge if we're happy with it.