Skip to content

Conversation

@markets
Copy link
Collaborator

@markets markets commented May 12, 2018

Closes #343

Users want to search others by member_uid

Implemented using current search based on Ransack. I followed this guide to map the integer to a char and make it work with the pg ILIKE.

EXTRA Allow to sort by the member_uid column

end

config.include Devise::TestHelpers, type: :controller
config.include Devise::Test::ControllerHelpers, type: :controller
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises a warning. Originally pushed in 75aa85d, and overridden by #333.

@markets
Copy link
Collaborator Author

markets commented May 12, 2018

Current build is "unstable" due to others test cases (not related to these changes), as noted by @rewritten in #351: cd25968.

@sauloperez
Copy link
Collaborator

Take a look at @rewritten 's PR cause it looks like he's working on it.

@markets
Copy link
Collaborator Author

markets commented May 14, 2018

👍 seems that it was solved there, I'll rebase on top when it get merged to develop, because both branches are also touching the ransack form.

Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase from develop @markets ?

Thanks!!!! 😍

Conflicts:
	app/views/users/index.html.erb
@markets
Copy link
Collaborator Author

markets commented May 17, 2018

Updated from develop, but 1 test case (https://travis-ci.org/coopdevs/timeoverflow/builds/380375042) is failing (maybe the ransacker mapping ¯\_(ツ)_/¯ ??), I'll take a closer look and I'll ping you for review.

@markets markets added the wip label May 17, 2018
@markets markets force-pushed the search_member_uid branch from a17471f to 22cda5d Compare May 18, 2018 00:13
@markets
Copy link
Collaborator Author

markets commented May 19, 2018

@enricostano @sauloperez Finally CI is green ✅ 😃

Ready for review 👀

Conflicts:
	app/views/users/index.html.erb
@markets
Copy link
Collaborator Author

markets commented Jun 13, 2018

Updated with latest develop and fixed conflitcts in app/views/users/index.html.erb file.

@sseerrggii
Copy link
Contributor

I changed the label to "need review" because you didn't merge it and I can not test it

@enricostano
Copy link
Contributor

Deployed on https://staging.timeoverflow.org/

@enricostano
Copy link
Contributor

Tested with @sseerrggii 🍏

@enricostano enricostano merged commit 394c0f6 into develop Aug 8, 2018
@enricostano enricostano deleted the search_member_uid branch August 8, 2018 11:01
@enricostano enricostano mentioned this pull request Aug 8, 2018
@sseerrggii sseerrggii mentioned this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants