Render partial with collection #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
approved these changes
Sep 4, 2018
|
It's not a big big change 😃 but it seems worth doing: https://medium.com/@coorasse/partial-rendering-performance-in-rails-101fdfb6ffb9 It's also the recommended way of rendering collections: https://guides.rubyonrails.org/layouts_and_rendering.html#rendering-collections |
markets
force-pushed
the
render_partial_with_collection
branch
from
e48e416 to
a17090b
Compare
|
Rebased (via merge) and deployed to staging |
|
Works fine for me! Thanks @markets 💪 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render partials (in
/members/manageand/members) using collection for speed 🏇 😄EXTRA
/members/managedon't redirect to/membersafter cancel membership (closes In /members/manage view don't redirect to /member after cancel membership #431): a17090b