Skip to content

Conversation

@markets
Copy link
Collaborator

@markets markets commented Feb 13, 2019

💎 https://github.com/colszowka/simplecov

Very useful 👌 as stated by @sauloperez in #281. I think we can configure Travis with Code Climate later.

After running the tests, you can open the generated PROJECT_ROOT/coverage/index.html file in a browser and you can see a detailed coverage report ✨

At this point 62.58% covered.

@markets
Copy link
Collaborator Author

markets commented Feb 14, 2019

Current build failed on Travis, but it seems totally unrelated to this PR.

All feature (capybara) specs failed, with same error: Net::ReadTimeout. I'd say this is something related to the ChromeDriver installation (or the add-on in Travis)... I see other branches failing with same error (I just rebased #421 and suite is failing with same error), so we'll need to take a look to this point.

@enricostano
Copy link
Contributor

I'd say this is something related to the ChromeDriver installation

@Morantron KEASECHO

@markets
Copy link
Collaborator Author

markets commented Feb 15, 2019

@Morantron @enricostano I started a branch to try fix this 👉 #461

First of all, I just upgraded gems to latest versions (basically because the chromedriver gem https://github.com/flavorjones/chromedriver-helper#known-issues has kwown issues with our current version), let's see what Travis says (it passes ✔️ for me in my local env)

@enricostano enricostano requested a review from sauloperez March 4, 2019 15:42
@markets
Copy link
Collaborator Author

markets commented Mar 11, 2019

@sauloperez friendly ping 😸

@sauloperez
Copy link
Collaborator

@sauloperez
Copy link
Collaborator

At this point 62.58% covered.

Not bad

@enricostano enricostano merged commit f421912 into develop Mar 13, 2019
@enricostano enricostano deleted the add_simplecov branch March 13, 2019 22:26
@enricostano
Copy link
Contributor

@markets @sauloperez are we going to add coverage check in CI?

@sauloperez
Copy link
Collaborator

We should. Otherwise, coverage is not that useful.

@enricostano enricostano added this to the 1.12.0 milestone Mar 14, 2019
@enricostano
Copy link
Contributor

I created an issue for that #476

@enricostano enricostano mentioned this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants