Fixing acceptance tests + upgrade dev deps #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
markets
force-pushed
the
fix_feature_specs
branch
from
53b8db5 to
ac2e1cb
Compare
|
Yay! after rebasing @enricostano @Morantron I think this is safe to merge, what do you think? |
enricostano
approved these changes
Feb 18, 2019
markets
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #459 (comment)
First, I just upgraded some dev deps (+ moved from
capybara-seleniumtoselenium-webdriver) and made some configuration tweaks... let's see what Travis says 👀