Skip to content

Fix favicon issue #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix favicon issue #488

merged 1 commit into from
Apr 10, 2019

Conversation

@markets
Copy link
Collaborator

@markets markets commented Apr 8, 2019

Closes #480
Closes #485

@markets markets marked this pull request as ready for review April 8, 2019 20:21
@sseerrggii
Copy link
Contributor

sseerrggii commented Apr 9, 2019

Tested on staging 👍

I see the favicon

enricostano
enricostano approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@enricostano enricostano merged commit 8d26302 into develop Apr 10, 2019
@enricostano enricostano deleted the fix_favicon branch April 10, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@enricostano enricostano enricostano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markets @sseerrggii @enricostano