Skip to content

Replace flavorjones/chromedriver-helper with titusfortner/webdrivers. #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2019
Merged

Replace flavorjones/chromedriver-helper with titusfortner/webdrivers. #491

merged 1 commit into from
Apr 14, 2019

Conversation

@markets
Copy link
Collaborator

@markets markets commented Apr 11, 2019 •
edited
Loading

Replace flavorjones/chromedriver-helper with titusfortner/webdrivers.

NOTICE: This gem is out of support as of 2019-03-31
Please use https://github.com/titusfortner/webdrivers instead.

See flavorjones/chromedriver-helper#83 for details.

@markets
Replace flavorjones/chromedriver-helper with titusfortner/webdrivers.
271a5be 
> NOTICE: This gem is out of support as of 2019-03-31
> Please use https://github.com/titusfortner/webdrivers instead.
>
> See flavorjones/chromedriver-helper#83 for details.
@markets
Copy link
Collaborator Author

markets commented Apr 11, 2019

@enricostano @Morantron @sauloperez Ready for review! flavorjones/chromedriver-helper was deprecated couple of weeks ago, time to move on!

enricostano
enricostano approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markets ❤️

@enricostano enricostano merged commit aa7f3d9 into develop Apr 14, 2019
@enricostano enricostano deleted the webdrivers branch April 14, 2019 14:44
@sseerrggii sseerrggii mentioned this pull request May 16, 2019
Merged
@enricostano enricostano mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@enricostano enricostano enricostano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markets @enricostano