sort members by last_sign_in_at by default #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in staging, works perfect! Thank you again @markets 💪
|
|
@sseerrggii @enricostano specs ✅ ready for review! |
enricostano
approved these changes
May 10, 2019
There was a problem hiding this comment.
Cool @markets 👏
Do you think we can also get green code coverage check? Thanks!!!
|
Not sure why % decreased... New lines are covered ¯_(ツ)_/¯ |
|
Yeah, it complains about the |
|
Tested on staging 🍏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #468
Solution extracted and adapted from activerecord-hackery/ransack#443.
I tried it locally and it seems to work well (even the
managepage with custom sorting).I'll fix/improve tests before merge, but maybe @sseerrggii you can take a quick look before 😁?
TODO: