Remove next environment #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricostano
approved these changes
Jan 21, 2020
It was used while migration the production server and since this one and production configs are almost exact copies (just rails_env differs) it's no longer needed. And this brings simplicity back to this repo. The most noticeable change is the removal of `url` from production's database config as DATABASE_URL got removed in coopdevs/timeoverflow-provisioning#21 two years ago and it's true in production: ``` timeoverflow@timeoverflow-production:~$ env | grep DATABASE DATABASE_NAME=xxx DATABASE_USER=xxx DATABASE_PASSWORD=xxx ```
sauloperez
force-pushed
the
remove-next-environment
branch
from
f4baf7d to
e572437
Compare
|
Rebased with the changes introduced in #536. No behavior changes 👌 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was used while migration the production server and since this one and production configs are almost exact copies (just rails_env differs) it's no longer needed.
And this brings simplicity back to this repo.
The most noticeable change is the removal of
urlfrom production's database config as DATABASE_URL got removed in coopdevs/timeoverflow-provisioning#21 two years ago and it's true in production: