sao: Do not expand invisible widgets #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PCLAS-753
Contributor
Author
|
Before :
After :
|
antoine-roulin
approved these changes
Apr 2, 2024
jmousset
previously approved these changes
Apr 2, 2024
nidhalk
reviewed
Apr 2, 2024
sao/src/view/form.js
Outdated
| var xexpand = attributes.xexpand; | ||
| if (xexpand === undefined) xexpand = 1; | ||
| if ((attributes.invisible === "1") || | ||
| (attributes.states === '{"invisible": true}')) { |
There was a problem hiding this comment.
JSON.parse(attributes.states).invisible === true
JCavallo
added a commit
that referenced
this pull request
Apr 11, 2024
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 3, 2024
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Jun 16, 2025
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Jun 19, 2025
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 11, 2025
JCavallo
added a commit
to JCavallo/tryton
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PCLAS-753