Update column visibility at the end of rendering the treeview [PREVIEW] #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For performance reasons it's better not to mix DOM reading and modifying especially in JS loops. PCLAS-772
Contributor
|
LGTM |
JCavallo
approved these changes
Apr 5, 2024
nicoe
added a commit
that referenced
this pull request
Apr 5, 2024
…W] (#187) For performance reasons it's better not to mix DOM reading and modifying especially in JS loops. PCLAS-772
| } | ||
| if (to_show.length) { | ||
| this.tbody.find(to_show.map(make_selector).join(',')) | ||
| .removeClass('invisible').show(); |
Contributor
There was a problem hiding this comment.
Petit problème ici avec jQuery qui repasse un coup de recalculate style sur tout le DOM en itérant sur le body j'ai l'impression. J'ai cherché des solutions pour éviter ça mais no luck.
Collaborator
Author
There was a problem hiding this comment.
Je pensais naïvement qu'en utilisant un selecteur ça ne ferait qu'une seule invalidation.
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 3, 2024
…STOM] PR: (coopengo#187) Fix #21005 Co-authored-by: Jérémy Mousset <jeremy.mousset@coopengo.com>
nicoe
added a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 3, 2024
…W] (coopengo#187) For performance reasons it's better not to mix DOM reading and modifying especially in JS loops. PCLAS-772
jmousset
added a commit
to jmousset/tryton
that referenced
this pull request
Jan 9, 2025
…STOM] PR: (coopengo#187) Fix #21005 Co-authored-by: Jérémy Mousset <jeremy.mousset@coopengo.com>
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Jun 16, 2025
…STOM] PR: (coopengo#187) Fix #21005 Co-authored-by: Jérémy Mousset <jeremy.mousset@coopengo.com>
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Jun 19, 2025
…STOM] PR: (coopengo#187) Fix #21005 Co-authored-by: Jérémy Mousset <jeremy.mousset@coopengo.com>
nicoe
pushed a commit
to nicoe/tryton-coopengo-new
that referenced
this pull request
Sep 11, 2025
…STOM] PR: (coopengo#187) Fix #21005 Co-authored-by: Jérémy Mousset <jeremy.mousset@coopengo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons it's better not to mix DOM reading and modifying especially in JS loops.
PCLAS-772