Skip to content

Reset completely the overflow for modal-body #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Reset completely the overflow for modal-body #395

merged 1 commit into from
Mar 13, 2025

Conversation

@nicoe
Copy link
Collaborator

@nicoe nicoe commented Feb 26, 2025

This one is a complicated beast:

- having defined an `overflow-x: auto` in CSS on modal-body make it a new Block Formatting Context
- Block Formatting Context contains their floating elements
- This is why although the ul menu is in the same stacking context than the modal footer, the menu does not appear above it.
- Thus setting the `overflow` property will also reset the `overflow-x` property and since the value is `visible` it does not create a new Block Formatting Context, ensuring the `z-index` take effect.

Fix PCLAS-1506

@nicoe
Reset completely the overflow for modal-body
3a5514b 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
@nicoe nicoe requested a review from JCavallo February 26, 2025 19:16
@nicoe nicoe merged commit 4b1b5f6 into coopengo:master Mar 13, 2025
1 check passed
nicoe added a commit that referenced this pull request Mar 13, 2025
@nicoe
[coog-24.41] Reset completely the overflow for modal-body (#395)
f57ef66 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
nicoe added a commit that referenced this pull request Mar 13, 2025
@nicoe
Reset completely the overflow for modal-body [CUSTOM] (#395)
54ee44a 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
nicoe added a commit to nicoe/tryton-coopengo-new that referenced this pull request Jun 16, 2025
@nicoe
Reset completely the overflow for modal-body [CUSTOM] (coopengo#395)
057d177 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
Fix PCLAS-1169
nicoe added a commit to nicoe/tryton-coopengo-new that referenced this pull request Jun 19, 2025
@nicoe
Reset completely the overflow for modal-body [CUSTOM] (coopengo#395)
8b5a0d1 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
Fix PCLAS-1169
nicoe added a commit to nicoe/tryton-coopengo-new that referenced this pull request Sep 11, 2025
@nicoe
Reset completely the overflow for modal-body [CUSTOM] (coopengo#395)
357bead 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
Fix PCLAS-1169
JCavallo pushed a commit to nicoe/tryton-coopengo-new that referenced this pull request Sep 12, 2025
@nicoe @JCavallo
Reset completely the overflow for modal-body [CUSTOM] (coopengo#395)
7ab24e0 
This one is a complicated beast:

    - having defined an `overflow-x: auto` in CSS on modal-body make it
      a new Block Formatting Context
    - Block Formatting Context contains their floating elements
    - This is why although the ul menu is in the same stacking context
      than the modal footer, the menu does not appear above it.
    - Thus setting the `overflow` property will also reset the
      `overflow-x` property and since the value is `visible` it does not
      create a new Block Formatting Context, ensuring the `z-index` take
      effect.

Fix PCLAS-1506
Fix PCLAS-1169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JCavallo JCavallo JCavallo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicoe @JCavallo