Merged
Conversation
25ec1a4 to
3d7a24a
Compare
There was a problem hiding this comment.
Pull request overview
Follow-up to #65/#57 to expand the set of Rust expressions supported inside #[thrust::formula_fn], primarily around array operations and additional term constructors.
Changes:
- Add
Arrayindexing andArray::storemodel definitions and wire upDefIdlookup forarray_store. - Extend
AnnotFnTranslatorto translate&expr,*expron shared refs,array[index],array.store(i, v), and struct constructors. - Adjust the injected model
Vecrepresentation (length usesInt) and add missingModelimpl formodel::Array.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
std.rs |
Adds Array indexing + store model hooks; tweaks model Vec and adds Model for model::Array. |
src/analyze/did_cache.rs |
Caches the DefId for the #[thrust::def::array_store]-annotated method. |
src/analyze/annot_fn.rs |
Implements new HIR-to-CHC translations for index/method-call/address-of/deref and struct ctors. |
src/analyze/annot.rs |
Adds the attribute path helper for thrust::def::array_store. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up of #65
extracted from #57