Specify spec of PartialEq and PartialOrd on trait method side for now#82
Merged
Specify spec of PartialEq and PartialOrd on trait method side for now#82
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds temporary, generic extern specs for PartialEq::eq and PartialOrd::{lt,gt} on the trait method side to avoid Thrust panicking on rustc-generated UFCS calls (e.g. <&i32 as PartialEq>::eq) that currently hit “unknown def” for blanket impls on references.
Changes:
- Add a generic extern spec for
PartialEq::eq. - Add generic extern specs for
PartialOrd::ltandPartialOrd::gt. - Document (via TODO) that these specs are intentionally imprecise pending better per-impl / blanket-impl support.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coord-e
force-pushed
the
coord-e/partialeq-partialord-spec
branch
from
42bb61a to
d0674c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes rustc generates PartialEq and PartialOrd method calls like
<&i32 as PartialEq>::eq. Since Thrust doesn't know how to type the DefId ofimpl<T> PartialEq for &T, it causes an "unknown def" panic. We should be able to handle these kinds of blanket impls, but it'll take some effort; we need to refer to the spec of<T as PartialEq>::eqwithin the spec of<&T as PartialEq>::eq, which isn't possible with the current annotation implementation.For now, this PR defines a simple PartialEq and PartialOrd specs applied for all implementors (as of #79) and leaves precise specs for blanket impls as future work.