Mocking stream endpoint #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And updating ‘item_id’ to ‘id’
It now makes sense to have a generic appendItemArray function
# Conflicts: # package.json
jde
reviewed
Nov 3, 2016
| comments: rootComments | ||
| })) | ||
|
|
||
| Object.keys(childComments).reduce((prev, key) => { |
There was a problem hiding this comment.
From @riley: since this block doesn't return things by keys, we should use a for each here.
jde
reviewed
Nov 3, 2016
routes/api/stream/index.js
Outdated
|
|
||
| router.get('/', (req, res) => { | ||
| console.log('Stream endpoint has been hit with asset_id ', req.query.asset_id) | ||
| res.setHeader('Content-Type', 'application/json'); |
There was a problem hiding this comment.
res.json() will take care of the header and stringify for you.
jde
reviewed
Nov 3, 2016
|
|
||
| const router = express.Router(); | ||
|
|
||
| router.get('/', (req, res) => { |
There was a problem hiding this comment.
Add a third param called next here, which can be used to pass errors down the first error handler it finds down the chain.
There was a problem hiding this comment.
we'll add it later. I think linting might fail if there are unused vars, and this is a mock for now.
And fixing a few small issues with item posting.
# Conflicts: # routes/api/index.js
res.json is not a Promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a stream endpoint that returns a static json object and adjusts the frontend to expect data of that format.
How do I test this PR?
npm run buildnpm starthttp://localhost:3000/client/coral-embed-stream/samplearticle.htmlNotes
npm buildscript for efficiency, someone with more of a handle on the architecture (i.e. @wyattjoh or @okbel) should feel free to refactor.