-
-
Notifications
You must be signed in to change notification settings - Fork 304
fix: resolve cutQuotedString issue with double backslashes (\\) #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
==========================================
+ Coverage 84.36% 84.37% +0.01%
==========================================
Files 170 170
Lines 9925 9933 +8
==========================================
+ Hits 8373 8381 +8
Misses 1308 1308
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fzipi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: update variable name.
Other than that, LGTM.
Apply suggestions from code review Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
This PR addresses an issue in the
corazawafcutQuotedStringfunction where the presence of backslashes (\\) in the operator value prevents proper parsing of the SecRule. This parsing failure leads to load configuration errors and does not allow users to write certain rules for corazawaf, resulting in potential misconfigurations.Make sure that you've checked the boxes below before you submit PR:
Thanks for your contribution ❤️