Skip to content

Conversation

@glarrain
Copy link
Contributor

Function get_rcv_csv_file_parser and its related type RcvCsvFileParserType.

Source: https://github.com/fyntex/fd-cl-data/blob/ab4469402c8e4d50656f443eb93c900127f27bdd/fd_cl_data/apps/sii_rcv/models.py#L899-L952

@glarrain glarrain added task Task or chore component: rcv labels Apr 13, 2020
@glarrain glarrain requested a review from jtrh April 13, 2020 19:34
@glarrain glarrain self-assigned this Apr 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #109 into develop will decrease coverage by 1.16%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
- Coverage    80.08%   78.91%   -1.17%     
===========================================
  Files           25       25              
  Lines         1647     1722      +75     
  Branches       254      279      +25     
===========================================
+ Hits          1319     1359      +40     
- Misses         222      248      +26     
- Partials       106      115       +9     
Impacted Files Coverage Δ
cl_sii/rcv/parse_csv.py 80.70% <18.18%> (-4.35%) ⬇️
cl_sii/dte/data_models.py 67.34% <61.11%> (+0.44%) ⬆️
cl_sii/dte/parse.py 82.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995af20...0a893b0. Read the comment docs.

@glarrain glarrain force-pushed the task/rcv/parse_csv/move-code branch from 0a893b0 to 52c0c0d Compare April 13, 2020 19:53
@glarrain glarrain merged commit 64cc860 into develop Apr 13, 2020
@glarrain glarrain deleted the task/rcv/parse_csv/move-code branch April 13, 2020 20:04
This was referenced Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants