Skip to content

Add support for Python 3.8 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2020
Merged

Add support for Python 3.8 #119

merged 3 commits into from
Jun 8, 2020

Conversation

@jtrh
Copy link
Contributor

@jtrh jtrh commented Jun 8, 2020 •
edited
Loading

@jtrh jtrh added the component: config config, setup, etc label Jun 8, 2020
@jtrh jtrh self-assigned this Jun 8, 2020
@jtrh jtrh requested a review from glarrain June 8, 2020 17:05
glarrain
glarrain approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@glarrain glarrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jtrh
Fix 'io_utils' test 'test_with_encoding_utf8'
f4b48d1 
The issue of `tempfile.SpooledTemporaryFile.encoding` being `None` when
the `encoding` parameter is `utf-8` affects only some Python versions.

Ref.: #120
@jtrh jtrh force-pushed the feature/add-python-3.8-support branch from 50d0b9a to f4b48d1 Compare June 8, 2020 17:44
@jtrh jtrh marked this pull request as ready for review June 8, 2020 17:46
@jtrh jtrh merged commit 6706ab8 into develop Jun 8, 2020
@jtrh jtrh deleted the feature/add-python-3.8-support branch June 8, 2020 17:49
@jtrh jtrh mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glarrain glarrain glarrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtrh jtrh

Labels

component: config config, setup, etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtrh @glarrain