dte.parse: change and improve clean_dte_xml
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests have not been implemented.
Augment and improve it to consider more cleaning operations. - Add `_set_dte_xml_missing_xmlns`. - Refactor `_remove_dte_xml_doc_personalizado` out of `clean_dte_xml`. Tests have not been implemented.
Test have not been implemented.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment and improve it to consider more cleaning operations.
Backwards compatibility
Breaks compatibility.
Signature changed from
clean_dte_xml(xml_doc: lxml.etree.ElementBase) -> boolto
clean_dte_xml(xml_doc: lxml.etree.ElementBase, set_missing_xmlns: bool = False, remove_doc_personalizado: bool = True) -> Tuple[lxml.etree.ElementBase, bool]Details
_set_dte_xml_missing_xmlns._remove_dte_xml_doc_personalizadoout ofclean_dte_xml.Tests have not been implemented (just a full "integration test" has).