-
Notifications
You must be signed in to change notification settings - Fork 12
rtc: Add data models and parser for AECs #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #180 +/- ##
===========================================
+ Coverage 78.65% 80.83% +2.18%
===========================================
Files 28 30 +2
Lines 2024 2505 +481
Branches 331 377 +46
===========================================
+ Hits 1592 2025 +433
- Misses 286 306 +20
- Partials 146 174 +28
Continue to review full report at Codecov.
|
505e70b to
63c8210
Compare
3713486 to
c20034d
Compare
- Add a data model for the SII's "Archivo Electrónico de Cesión" (AEC) in XML format. - Add a data model for the "cesiones" contained in an AEC.
c20034d to
b9e80cd
Compare
b9e80cd to
bc6ad3c
Compare
yaselc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow... 🤯
Just add that you should include the "Identificador de Envio" field, from the RPETC email:
RPETC email: attachment / 'Identificador de Envio'
This is a key piece of information to check the status of an AEC submission and can only be obtained from the RPETC email or submitting the AEC.
@yaselc Can I extract the "identificador de envío" from the contents of an AEC XML file? The scope of this pull request is modelling and parsing an AEC in XML format, not other related entities such as the RPETC email, unless those entities are embedded in the AEC XML file. |
Of course, that does not exclude the possibility of creating a separate data model for the RPETC Email Message in a future pull request. |
Makes sense, but I'm thinking here of the use case that FP generates the AEC and submits it to the SII, the response is the "Identificador de Envio" and FP will want to store this AEC together with the "Identificador de Envio" to later check its status. |
I agree |
@yaselc: We can store the submission identifier in an optional field of the AEC Django model of FD CL Data. |
Uh oh!
There was an error while loading. Please reload this page.