Skip to content

dte: many improvements #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 23, 2019
Merged

dte: many improvements #21

merged 9 commits into from
Apr 23, 2019

Conversation

@glarrain
Copy link
Contributor

@glarrain glarrain commented Apr 23, 2019

Summary

  • Add fields to data_models.DteDataL2.
  • Add properties to data_models.DteDataL1.
  • Re-implement, improve and augment parse.parse_dte_xml.
  • Add helper properties to TipoDteEnum.
  • Implement missing tests for data_models.
  • Implement missing tests for constants.

Detail

data_models

  • Add fields to DteDataL2:
    • firma_documento_dt_naive
    • signature_value_base64
    • signature_x509_cert_base64
    • emisor_giro
    • emisor_email
    • receptor_email
  • Add properties to DteDataL1:
    • vendedor_rut
    • deudor_rut
  • Remove redundant property DteDataL1.natural_key
  • Implement missing tests (and add some test stubs).

parse

  • Re-implement, improve and augment parse_dte_xml.
  • Improve tests.
  • Fix poor usage of 'lxml'.

constants

  • Add helper properties to TipoDteEnum.
  • Improve docstrings and comments a little.
  • Implement tests.

glarrain added 9 commits April 22, 2019 19:50
@glarrain
dte.constants: add features to TipoDteEnum
fb87ffa 
Add helper properties.

Also:
- Improve docstrings and comments a little.
- Implement tests.
@glarrain
dte.parse: fix poor usage of 'lxml'
0bde60b
@glarrain
dte.data_models: remove redundant property
95b1f3e
@glarrain
dte.data_models: implement tests
3509a34 
And add some test stubs.
@glarrain
dte.data_models: add properties to DteDataL1
1a3d5e4 
- `vendedor_rut`
- `deudor_rut`
@glarrain
dte.parse: improve tests
24c0411
@glarrain
dte.parse: refactor parse_dte_xml
55b9ace
@glarrain
dte.parse: augment parse_dte_xml
1445d01
@glarrain
dte.data_models: add fields to DteDataL2
89196d3 
- `firma_documento_dt_naive`
- `signature_value_base64`
- `signature_x509_cert_base64`
- `emisor_giro`
- `emisor_email`
- `receptor_email`
@glarrain glarrain self-assigned this Apr 23, 2019
@glarrain glarrain merged commit e04e694 into develop Apr 23, 2019
@glarrain glarrain deleted the feature/dte/many-improvements branch April 23, 2019 00:29
glarrain added a commit that referenced this pull request Apr 25, 2019
@glarrain
dte.data_models: modify new fields of DteDataL2
7d8e32b 
Modify 2 fields added to `DteDataL2` in 89196d3 (PR #21).
That introduces some changes to function `parse_dte_xml`.

Also includes a major reorganization of tests for module `parse`,
improving separate coverage.
This was referenced Apr 25, 2019
Merged
Merged
@jtrobles-cdd jtrobles-cdd added enhancement New feature or request and removed feature labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glarrain glarrain

Labels

component: dte enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glarrain @jtrobles-cdd