dte.data_models: alter field DteDataL2.signature_x509_cert_pem
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to `signature_x509_cert_der` and hold the X.509 certificate's DER-encoded data instead of PEM-encoded data. **Breaks backwards compatibility**.
Codecov Report
@@ Coverage Diff @@
## develop #38 +/- ##
==========================================
- Coverage 72.17% 71.7% -0.47%
==========================================
Files 16 16
Lines 769 767 -2
Branches 101 101
==========================================
- Hits 555 550 -5
- Misses 173 174 +1
- Partials 41 43 +2
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to
signature_x509_cert_derand hold the X.509 certificate's DER-encoded data instead of PEM-encoded data.Breaks backwards compatibility.