Skip to content

Conversation

@svillegas-cdd
Copy link
Contributor

@svillegas-cdd svillegas-cdd commented Jan 31, 2023

@svillegas-cdd svillegas-cdd added task Task or chore dependencies Pull requests that update a dependency file labels Jan 31, 2023
@svillegas-cdd svillegas-cdd self-assigned this Jan 31, 2023
@svillegas-cdd svillegas-cdd requested a review from a team as a code owner January 31, 2023 16:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 85.72% // Head: 85.94% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (c2fe7f2) compared to base (871426b).
Patch coverage: 85.96% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #426      +/-   ##
===========================================
+ Coverage    85.72%   85.94%   +0.21%     
===========================================
  Files           34       34              
  Lines         2767     2760       -7     
  Branches       353      350       -3     
===========================================
  Hits          2372     2372              
+ Misses         258      252       -6     
+ Partials       137      136       -1     
Impacted Files Coverage Δ
cl_sii/libs/mm_utils.py 52.94% <42.85%> (+0.94%) ⬆️
cl_sii/extras/mm_fields.py 100.00% <100.00%> (ø)
cl_sii/libs/rows_processing.py 61.76% <100.00%> (+8.27%) ⬆️
cl_sii/rcv/parse_csv.py 78.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@svillegas-cdd svillegas-cdd force-pushed the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch from 76847f9 to c0025c6 Compare January 31, 2023 18:06
@fpinto-cdd fpinto-cdd self-requested a review February 1, 2023 17:49
@svillegas-cdd svillegas-cdd force-pushed the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch from c0025c6 to 9adce1b Compare February 3, 2023 16:07
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Partial review

Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add empty line between Ref: ... and ---:
    image
  • Fix rendered PR description:

image

Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svillegas-cdd svillegas-cdd force-pushed the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch from 9adce1b to a3c19d2 Compare February 6, 2023 13:29
@svillegas-cdd svillegas-cdd force-pushed the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch 2 times, most recently from 39b54cf to 12ae8cf Compare February 8, 2023 15:16
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumps [marshmallow](https://github.com/marshmallow-code/marshmallow) from 2.21.0 to 3.19.0.
- [Release notes](https://marshmallow.readthedocs.io/en/stable/changelog.html)
- [Commits](marshmallow-code/marshmallow@2.21.0...3.19.0)
- [Upgrading guide](https://marshmallow.readthedocs.io/en/stable/upgrading.html#upgrading-to-3-0)

Ref: https://cordada.aha.io/features/COMPCLDATA-201

---
updated-dependencies:
- dependency-name: marshmallow
- dependency-type: direct:production
- update-type: version-update:semver-major
...
@svillegas-cdd svillegas-cdd force-pushed the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch 2 times, most recently from c2fe7f2 to 0e1b0e4 Compare February 8, 2023 16:15
Changes were done by following the guide:
https://marshmallow.readthedocs.io/en/stable/upgrading.html#upgrading-to-3-0

* Added `**kwargs` param to `_deserialize` and `serialize` functions
* Changed `load_from` to `data_key` param in Schemas
* Updated test to work handle error properly
* Replaced deprecated `Field.fail` for `Field.make_error`

Ref: https://cordada.aha.io/features/COMPCLDATA-201
@svillegas-cdd svillegas-cdd force-pushed the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch from 0e1b0e4 to 6ff9db7 Compare February 8, 2023 20:44
@svillegas-cdd svillegas-cdd merged commit ea5f5e6 into develop Feb 8, 2023
@svillegas-cdd svillegas-cdd deleted the task/COMPCLDATA-201-update-marshmallow-to-major-version-3 branch February 8, 2023 21:05
@jtrobles-cdd jtrobles-cdd mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file task Task or chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants