Skip to content

Improve type checking #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Improve type checking #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4596d83
chore: Install Python package 'types-pyOpenSSL'
jtrobles-cdd Feb 3, 2023
2f5341a
chore: Enable type checking for `OpenSSL`
jtrobles-cdd Feb 3, 2023
2c165ef
chore: Enable type checking for `cryptography`
jtrobles-cdd Feb 3, 2023
197b653
chore: Install Python package 'types-jsonschema'
jtrobles-cdd Feb 3, 2023
636b0f4
chore: Enable type checking for `jsonschema`
jtrobles-cdd Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cl_sii/libs/xml_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ def write_xml_doc(xml_doc: XmlElement, output: IO[bytes]) -> None:

def verify_xml_signature(
xml_doc: XmlElement,
trusted_x509_cert: Union[crypto_utils.X509Cert, crypto_utils._X509CertOpenSsl] = None,
trusted_x509_cert: Optional[Union[crypto_utils.X509Cert, crypto_utils._X509CertOpenSsl]] = None,
xml_verifier: Optional[signxml.XMLVerifier] = None,
xml_verifier_supports_multiple_signatures: bool = False,
) -> Tuple[bytes, XmlElementTree, XmlElementTree]:
Expand Down
9 changes: 0 additions & 9 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,18 @@ show_error_codes = True
show_error_context = True
error_summary = True

[mypy-cryptography.*]
ignore_missing_imports = True

[mypy-defusedxml.*]
ignore_missing_imports = True

[mypy-django.*]
ignore_missing_imports = True

[mypy-jsonschema]
ignore_missing_imports = True

[mypy-lxml.*]
ignore_missing_imports = True

[mypy-marshmallow.*]
ignore_missing_imports = True

[mypy-OpenSSL.*]
ignore_missing_imports = True

[mypy-rest_framework.*]
ignore_missing_imports = True

Expand Down
2 changes: 2 additions & 0 deletions requirements-dev.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,7 @@ isort==5.10.1
mypy==0.991
tox==3.25.1
twine==3.1.1
types-jsonschema==4.17.0.3
types-pyOpenSSL==23.0.0.2
types-pytz==2022.7.1.0
wheel==0.38.4
5 changes: 5 additions & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ cryptography==38.0.4
# via
# -c requirements.txt
# secretstorage
# types-pyopenssl
distlib==0.3.6
# via virtualenv
docutils==0.19
Expand Down Expand Up @@ -129,6 +130,10 @@ typed-ast==1.5.4
# via
# black
# mypy
types-jsonschema==4.17.0.3
# via -r requirements-dev.in
types-pyopenssl==23.0.0.2
# via -r requirements-dev.in
types-pytz==2022.7.1.0
# via -r requirements-dev.in
typing-extensions==4.3.0
Expand Down