Skip to content

libs.encoding_utils: improve clean_base64 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2019
Merged

libs.encoding_utils: improve clean_base64 #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cl_sii/libs/encoding_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ def clean_base64(value: Union[str, bytes]) -> bytes:
raise TypeError("Value must be str or bytes.")

# remove line breaks and spaces
value_base64_bytes_cleaned = value_base64_bytes.replace(b'\n', b'').replace(b' ', b'')
# warning: we may only remove characters that are not part of the standard base-64 alphabet
# (or any of its popular alternatives).
value_base64_bytes_cleaned = value_base64_bytes \
.replace(b'\n', b'') \
.replace(b'\r', b'') \
.replace(b'\t', b'') \
.replace(b' ', b'')

return value_base64_bytes_cleaned

Expand Down