Skip to content

Migrate to pydantic==2.4.2 #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2023
Merged

Migrate to pydantic==2.4.2 #544

merged 2 commits into from
Oct 23, 2023

Conversation

@svillegas-cdd
Copy link
Contributor

@svillegas-cdd svillegas-cdd commented Sep 26, 2023

@svillegas-cdd svillegas-cdd self-assigned this Sep 26, 2023
@shortcut-integration
Copy link

shortcut-integration bot commented Sep 26, 2023

This pull request has been linked to Shortcut Story #768: Update Lib-CL-SII-Python.

@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch 2 times, most recently from e75fca9 to 03c458f Compare September 26, 2023 20:50
@svillegas-cdd svillegas-cdd changed the title WIP: Update to pydantic==2.3.0 Migrate to pydantic==2.3.0 Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #544 (d4962a2) into develop (02617d3) will increase coverage by 0.16%.
The diff coverage is 98.00%.

@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
+ Coverage    86.82%   86.98%   +0.16%     
===========================================
  Files           34       34              
  Lines         3005     3013       +8     
  Branches       380      377       -3     
===========================================
+ Hits          2609     2621      +12     
+ Misses         257      250       -7     
- Partials       139      142       +3
Files Coverage Δ
src/cl_sii/dte/data_models.py 96.92% <100.00%> (-0.52%) ⬇️
src/cl_sii/dte/parse.py 84.61% <100.00%> (-0.39%) ⬇️
src/cl_sii/rcv/data_models.py 82.32% <100.00%> (+2.32%) ⬆️
src/cl_sii/rtc/data_models.py 92.00% <100.00%> (-0.53%) ⬇️
src/cl_sii/rtc/data_models_aec.py 91.46% <100.00%> (+0.32%) ⬆️
src/cl_sii/rtc/parse_aec.py 93.46% <91.66%> (+1.24%) ⬆️

@svillegas-cdd svillegas-cdd changed the title Migrate to pydantic==2.3.0 WIP: Migrate to pydantic==2.3.0 Sep 27, 2023
@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch 2 times, most recently from 59dd86e to b16c07a Compare September 27, 2023 17:34
@svillegas-cdd svillegas-cdd changed the title WIP: Migrate to pydantic==2.3.0 Migrate to pydantic==2.3.0 Sep 27, 2023
@svillegas-cdd svillegas-cdd marked this pull request as ready for review September 27, 2023 17:38
@svillegas-cdd svillegas-cdd requested a review from a team as a code owner September 27, 2023 17:38
jtrobles-cdd
jtrobles-cdd requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Partial review

@svillegas-cdd svillegas-cdd changed the title Migrate to pydantic==2.3.0 Migrate to pydantic==2.4.2 Oct 2, 2023
@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch from b16c07a to bb4e95e Compare October 2, 2023 19:24
jtrobles-cdd
jtrobles-cdd requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Partial review

jtrobles-cdd
jtrobles-cdd requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Partial review

@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch 9 times, most recently from 9536534 to 9fab8f6 Compare October 5, 2023 20:18
@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch 3 times, most recently from d9defdb to 6a07d46 Compare October 5, 2023 20:34
@svillegas-cdd
Copy link
Contributor Author

svillegas-cdd commented Oct 5, 2023

SonarLint is taking the expected_validation_errors and the field_validators as code duplications

@jtrobles-cdd
Copy link
Member

jtrobles-cdd commented Oct 5, 2023

SonarLint is taking the expected_validation_errors and the field_validators as code duplications

Let's ignore SonarCloud and SonarLint for now.

jtrobles-cdd
jtrobles-cdd requested changes Oct 18, 2023
View reviewed changes
@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch 3 times, most recently from 82b68b9 to a552bd5 Compare October 19, 2023 15:09
jtrobles-cdd
jtrobles-cdd requested changes Oct 20, 2023
View reviewed changes
@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch from a552bd5 to 5f820db Compare October 23, 2023 12:47
@svillegas-cdd svillegas-cdd force-pushed the task/sc-768-update-lib-cl-sii-python branch from 5f820db to d4962a2 Compare October 23, 2023 12:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.6% 12.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svillegas-cdd svillegas-cdd merged commit d1297e5 into develop Oct 23, 2023
@svillegas-cdd svillegas-cdd deleted the task/sc-768-update-lib-cl-sii-python branch October 23, 2023 20:22
@svillegas-cdd svillegas-cdd mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtrobles-cdd jtrobles-cdd jtrobles-cdd approved these changes

@fpinto-cdd fpinto-cdd fpinto-cdd approved these changes

Assignees

@svillegas-cdd svillegas-cdd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@svillegas-cdd @jtrobles-cdd @fpinto-cdd