Skip to content

Fix GitHub code scanning alerts 'Clear-text logging of sensitive info' #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix GitHub code scanning alerts 'Clear-text logging of sensitive info' #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/cl_sii/libs/xml_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,10 @@ def parse_untrusted_xml(value: bytes) -> XmlElement:
# "parsing aborted"
# "out of memory"

# For sanity crop the XML-encoded content to max 1 KiB (arbitrary value).
log_msg = "Unexpected XML 'ExpatError' at line {} offset {}: {}. Content: %s".format(
log_msg = "Unexpected XML 'ExpatError' at line {} offset {}: {}.".format(
exc.lineno, exc.offset, xml.parsers.expat.errors.messages[exc.code]
)
logger.exception(log_msg, str(value[:1024]))
logger.exception(log_msg)

exc_msg = "Unexpected error while parsing value as XML. Line {}, offset {}.".format(
exc.lineno, exc.offset
Expand All @@ -249,9 +248,8 @@ def parse_untrusted_xml(value: bytes) -> XmlElement:
# it is just to raise the same exception with the same message) because it is a good
# idea to determine whether the source of the problem really is the response content.

# For sanity crop the XML-encoded content to max 1 KiB (arbitrary value).
log_msg = "Unexpected 'LxmlError' that is not an 'XMLSyntaxError'. Content: %s"
logger.exception(log_msg, str(value[:1024]))
log_msg = "Unexpected 'LxmlError' that is not an 'XMLSyntaxError'."
logger.exception(log_msg)

exc_msg = "Unexpected error while parsing value as XML."
raise UnknownXmlParsingError(exc_msg) from exc
Expand All @@ -261,9 +259,8 @@ def parse_untrusted_xml(value: bytes) -> XmlElement:
# it is just to raise the same exception with the same message) because it is a good
# idea to determine whether the source of the problem really is the response content.

# For sanity crop the XML-encoded content to max 1 KiB (arbitrary value).
log_msg = "Unexpected error while parsing value as XML. Content: %s"
logger.exception(log_msg, str(value[:1024]))
log_msg = "Unexpected error while parsing value as XML."
logger.exception(log_msg)

exc_msg = "Unexpected error while parsing value as XML."
raise UnknownXmlParsingError(exc_msg) from exc
Expand Down
4 changes: 1 addition & 3 deletions src/cl_sii/rtc/xml_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,7 @@ def verify_aec_signature(
except Exception:
signature_verified = None
logger.exception(
"Unexpected error when trying to verify digital signature of XML document. "
"X509 certificate: %s",
signature_x509_cert,
"Unexpected error when trying to verify digital signature of XML document."
)
else:
signature_verified = True
Expand Down