dte: Improve validation error message in DteXmlData.referencias
#557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #1493: Improve error message of |
Codecov Report
@@ Coverage Diff @@
## develop #557 +/- ##
========================================
Coverage 86.98% 86.98%
========================================
Files 34 34
Lines 3013 3013
Branches 377 378 +1
========================================
Hits 2621 2621
Misses 250 250
Partials 142 142
|
jtrobles-cdd
requested changes
Nov 8, 2023
* Improved exception message at `.DteXmlData.validate_referencias_numero_linea_ref_order` * Included Expected an actual value * Added list of all actual values or `DteXmlData.referencias` in message Ref: https://app.shortcut.com/cordada/story/1493/
svillegas-cdd
force-pushed
the
task/sc-1493-improve-error-message-of-cl-sii-dte-data
branch
from
e50a6b5 to
a5ca833
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jtrobles-cdd
approved these changes
Nov 8, 2023
jtrobles-cdd
changed the title
DteXmlData.referencias
svillegas-cdd
deleted the
task/sc-1493-improve-error-message-of-cl-sii-dte-data
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.DteXmlData.validate_referencias_numero_linea_ref_orderDteXmlData.referenciasin messageRef: https://app.shortcut.com/cordada/story/1493/