Skip to content

Conversation

@jtrobles-cdd
Copy link
Member

  • Add Django URL path converter for Chilean RUT.
  • Add Django URL path converter for Tipo DTE.
  • Add tests.

The source code originates from an internal application (see commits 1e0b3617 and 7db9b2b0 of that application’s source code), and was originally written by Jose Tomas Robles Hahn (RutConverter) and Felipe Pinto (TipoDteConverter).

@jtrobles-cdd jtrobles-cdd added the enhancement New feature or request label Jul 17, 2024
@jtrobles-cdd jtrobles-cdd requested a review from fpinto-cdd July 17, 2024 22:10
@jtrobles-cdd jtrobles-cdd self-assigned this Jul 17, 2024
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner July 17, 2024 22:10
@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (deb91cd) to head (fe686df).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #662      +/-   ##
===========================================
+ Coverage    86.97%   87.04%   +0.06%     
===========================================
  Files           35       36       +1     
  Lines         3040     3056      +16     
  Branches       379      379              
===========================================
+ Hits          2644     2660      +16     
  Misses         254      254              
  Partials       142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add Django URL path converter for Chilean RUT.
- Add Django URL path converter for Tipo DTE.
- Add tests.

The source code originates from an internal application
(see commits 1e0b3617 and 7db9b2b0 of that application’s source code),
and was originally written by Jose Tomas Robles Hahn (`RutConverter`)
and Felipe Pinto (`TipoDteConverter`).

Co-authored-by: Felipe Pinto <fpinto@cordada.com>
@jtrobles-cdd jtrobles-cdd force-pushed the feature/add-django-url-utils branch from d5bd0e6 to fe686df Compare July 17, 2024 22:16
@sonarqubecloud
Copy link

@jtrobles-cdd jtrobles-cdd merged commit bbb986b into develop Jul 17, 2024
@jtrobles-cdd jtrobles-cdd deleted the feature/add-django-url-utils branch July 17, 2024 22:26
@jtrobles-cdd jtrobles-cdd mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants