Skip to content

Conversation

@jtrobles-cdd
Copy link
Member

  • Add GitHub Actions workflow to release and deploy.

  • Trigger Git Commit Linter when a draft PR is ready for review.

    GitHub Actions does not create a new workflow run for events triggered
    by the GitHub Actions authentication token (secrets.GITHUB_TOKEN),
    which results in the Git Commit Linter’s workflow not being triggered
    when pull requests are created using GitHub Actions.

    This commit adds ready_for_review to the event types that trigger the
    GitHub Actions workflow 'Git Commit Linter' so that it runs for
    pull requests created using GitHub Actions when they are marked as
    ready for review by a user.

    From Automatic token authentication:

    When you use the repository's GITHUB_TOKEN to perform tasks, events
    triggered by the GITHUB_TOKEN, with the exception of
    workflow_dispatch and repository_dispatch, will not create a new
    workflow run. This prevents you from accidentally creating recursive
    workflow runs. For example, if a workflow run pushes code using the
    repository's GITHUB_TOKEN, a new workflow will not run even when the
    repository contains a workflow configured to run when push events occur.

GitHub Actions does not create a new workflow run for events triggered
by the GitHub Actions authentication token (`secrets.GITHUB_TOKEN`),
which results in the Git Commit Linter’s workflow not being triggered
when pull requests are created using GitHub Actions.

This commit adds `ready_for_review` to the event types that trigger the
GitHub Actions workflow 'Git Commit Linter' so that it runs for
pull requests created using GitHub Actions when they are marked as
ready for review by a user.

From [Automatic token authentication](https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication):

> When you use the repository's `GITHUB_TOKEN` to perform tasks, events
> triggered by the `GITHUB_TOKEN`, with the exception of
> `workflow_dispatch` and `repository_dispatch`, will not create a new
> workflow run. This prevents you from accidentally creating recursive
> workflow runs. For example, if a workflow run pushes code using the
> repository's `GITHUB_TOKEN`, a new workflow will not run even when the
> repository contains a workflow configured to run when `push` events
> occur.
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner March 26, 2025 16:59
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (3505b83) to head (dd85540).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #790   +/-   ##
========================================
  Coverage    87.39%   87.39%           
========================================
  Files           38       38           
  Lines         3166     3166           
  Branches       318      318           
========================================
  Hits          2767     2767           
  Misses         257      257           
  Partials       142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jtrobles-cdd jtrobles-cdd self-assigned this Mar 26, 2025
@jtrobles-cdd jtrobles-cdd added the task Task or chore label Mar 26, 2025
@jtrobles-cdd jtrobles-cdd merged commit 54609f9 into develop Mar 26, 2025
19 checks passed
@jtrobles-cdd jtrobles-cdd deleted the ci-cd-task-release-and-deploy branch March 26, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Task or chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants