Skip to content

Conversation

@github-actions
Copy link

Ref: #880

jtrobles-cdd and others added 8 commits September 10, 2025 10:30
Refactor how substring lookups are handled for Chilean RUT fields in
Django filters, centralizing logic in the `RutFilter` class and
improving test coverage.

The main change is that the selection of the form field class for
substring lookups (like `contains` and `icontains`) is now handled
within `RutFilter.__init__()`, instead of being managed by a custom
`filter_for_lookup()` override in `SiiFilterSet`. This results in
cleaner code and more reliable behavior.

Key changes include:

- Refactoring and Logic Centralization:
  - Moved the logic for selecting the appropriate `field_class` for
    substring lookups (`contains`, `icontains`) from `SiiFilterSet.filter_for_lookup()`
    into the `RutFilter` constructor, ensuring that substring lookups
    use a plain `CharField` instead of a strict `RutField` that would
    fail on invalid substrings.
- Test Enhancements:
  - Added comprehensive tests for `RutFilter` to verify that the correct
    `field_class` is chosen for each lookup expression, and for
    `SiiFilterSet` to ensure `filter_for_lookup()` returns filters with
    the correct field classes for different lookup types.
extras: Improve Django filter for `Rut`
Bumps the github-actions-production group with 2 updates: [actions/setup-python](https://github.com/actions/setup-python) and [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `actions/setup-python` from 5.6.0 to 6.0.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.6.0...v6.0.0)

Updates `codecov/codecov-action` from 5.5.0 to 5.5.1
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@fdcc847...5a10915)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-production
- dependency-name: codecov/codecov-action
  dependency-version: 5.5.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-actions-production-0563b434fb

chore(deps): Bump the github-actions-production group with 2 updates
@github-actions github-actions bot added task Task or chore kind: deploy Deployment labels Sep 10, 2025
@sonarqubecloud
Copy link

@jtrobles-cdd jtrobles-cdd marked this pull request as ready for review September 10, 2025 14:14
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner September 10, 2025 14:14
@jtrobles-cdd jtrobles-cdd merged commit 0e0c24a into master Sep 10, 2025
25 checks passed
@jtrobles-cdd jtrobles-cdd deleted the deploy/v0.55.0 branch September 10, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: deploy Deployment task Task or chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants