extras: Improve Django filters FILTER_FOR_DBFIELD_DEFAULTS
#884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `cl_sii.extras.dj_filters.FILTER_FOR_DBFIELD_DEFAULTS` consisted of the `FILTER_FOR_DBFIELD_DEFAULTS` from `django_filters`, with the addition of `RutFilter`. From now on, `cl_sii.extras.dj_filters.FILTER_FOR_DBFIELD_DEFAULTS` will only include the filters provided by `cl_sii`, leaving the user to decide whether to merge it with the one from `django_filters`.⚠️ Warning: Breaking change.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #884 +/- ##
===========================================
- Coverage 88.82% 88.81% -0.01%
===========================================
Files 38 38
Lines 3498 3497 -1
Branches 342 342
===========================================
- Hits 3107 3106 -1
Misses 239 239
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
⚠️ Warning: Breaking change.
cl_sii.extras.dj_filters.FILTER_FOR_DBFIELD_DEFAULTSconsisted of theFILTER_FOR_DBFIELD_DEFAULTSfromdjango_filters, with the addition ofRutFilter. From now on,cl_sii.extras.dj_filters.FILTER_FOR_DBFIELD_DEFAULTSwill only include the filters provided bycl_sii, leaving the user to decide whether to merge it with the one fromdjango_filters.