Skip to content

rcv: Refactor and extend parsing for "Otros Impuestos" field #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

rcv: Refactor and extend parsing for "Otros Impuestos" field #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 21 additions & 29 deletions src/cl_sii/rcv/data_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
from __future__ import annotations

import logging
from collections.abc import Sequence
from datetime import date, datetime
from decimal import Decimal
from typing import ClassVar, Optional

import pydantic
from typing_extensions import Self
from typing_extensions import Self, TypedDict

import cl_sii.dte.data_models
from cl_sii.base.constants import SII_OFFICIAL_TZ
Expand Down Expand Up @@ -102,6 +103,23 @@ def as_datetime(self) -> datetime:
)


class OtrosImpuestos(TypedDict):
codigo_otro_impuesto: Optional[str]
"""
Codigo Otro Imp.
"""

valor_otro_impuesto: Optional[int]
"""
Valor Otro Imp.
"""

tasa_otro_impuesto: Optional[Decimal]
"""
Tasa Otro Imp.
"""


@pydantic.dataclasses.dataclass(
frozen=True,
config=pydantic.ConfigDict(
Expand Down Expand Up @@ -414,20 +432,7 @@ class RvDetalleEntry(RcvDetalleEntry):
NCE o NDE sobre Fact. de Compra
"""

codigo_otro_imp: Optional[str]
"""
Codigo Otro Imp.
"""

valor_otro_imp: Optional[int]
"""
Valor Otro Imp.
"""

tasa_otro_imp: Optional[float]
"""
Tasa Otro Imp.
"""
otros_impuestos: Optional[Sequence[OtrosImpuestos]]

###########################################################################
# Validators
Expand Down Expand Up @@ -537,20 +542,7 @@ class RcDetalleEntry(RcvDetalleEntry):
NCE o NDE sobre Fact. de Compra
"""

codigo_otro_impuesto: Optional[str]
"""
Codigo Otro Impuesto
"""

valor_otro_impuesto: Optional[int]
"""
Valor Otro Impuesto
"""

tasa_otro_impuesto: Optional[Decimal]
"""
Tasa Otro Impuesto
"""
otros_impuestos: Optional[Sequence[OtrosImpuestos]]

###########################################################################
# Validators
Expand Down
Loading
Loading