feat(modules): fix inject style in safari#336
Merged
Conversation
🦋 Changeset detectedLatest commit: 8245ff4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heymdall-legal
approved these changes
Jul 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Какая проблема?
Движок webkit (Safari) иначе обрабатывает инъекцию стилей, чем движок v8, вследствие чего, при медленном интернете и/или большом кол-ве микрофронтовых модулей, которые добавляют стили через link, может ломаться верстка загруженных модулей
Происходит это из-за того, что Safari ждёт полной загрузки файлов стилей перед тем как обновить CSSOM
Решение
Чтобы решить эту проблему предлагаю инжектить стили для Safari inline способом
На видео отображено как было и как стало. Был специально замедлен один из запросов загрузки стилей (колокольчик в шапке), чтобы наглядно отобразить проблему
default.mp4
default.mp4