Merged
Conversation
Pull Request Test Coverage Report for Build 2670980676
💛 - Coveralls |
v-gevak
reviewed
Jul 6, 2022
v-gevak
reviewed
Jul 6, 2022
packages/tabs/src/components/tabs/Component.mobile/Component.mobile.tsx
Outdated
Show resolved
Hide resolved
v-gevak
reviewed
Jul 6, 2022
Collaborator
|
Собрана новая демка. |
v-gevak
approved these changes
Jul 6, 2022
churicheva-v
approved these changes
Jul 6, 2022
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
reme3d2y
reviewed
Jul 8, 2022
| const scrollableContainerNode = scrollableContainerRef.current; | ||
| const containerNode = containerRef.current; | ||
|
|
||
| if (containerNode && isFullScroll) { |
Contributor
There was a problem hiding this comment.
Можно упростить до
const scrollableNode = scrollableContainerRef.current || containerRef.current;
if (isFullScroll && scrollableNode) {
const { scrollWidth, clientWidth } = scrollableNode;
if (scrollWidth > clientWidth) {
setIsRightOut(true);
}
}
reme3d2y
reviewed
Jul 8, 2022
|
|
||
| if (containerNode) { | ||
| if (node.scrollLeft) { | ||
| setIsLeftOut(true); |
Contributor
There was a problem hiding this comment.
setIsLeftOut(node.scrollLeft !== 0)и ниже так же
reme3d2y
reviewed
Jul 8, 2022
| // TODO: animate? | ||
| actions.forEach(({ el, left }) => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| el.scrollLeft = el.scrollLeft > left ? left - 40 : left + 40; |
Contributor
There was a problem hiding this comment.
40 — magic number. Стоит вынести в константу или пропс и описать
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
v-gevak
approved these changes
Jul 12, 2022
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
Collaborator
|
Собрана новая демка. |
Oladii
approved these changes
Jul 14, 2022
vyushev
approved these changes
Jul 15, 2022
Collaborator
|
Собрана новая демка. |
EGNKupava
changed the title
EGNKupava
changed the title
EGNKupava
approved these changes
Jul 18, 2022
Collaborator
|
🎉 This PR is included in version 28.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавил пропс "fullWidth" в компонент TabsMobile для растягивания табов, заменил useEffect с добавлением стилей для линии под табом на useLayoutEffect