Меняем внутренние отступы у тегов и фильтртегов во всех темах#1416
Merged
fulcanellee merged 3 commits intomasterfrom Oct 24, 2024
Merged
Меняем внутренние отступы у тегов и фильтртегов во всех темах#1416fulcanellee merged 3 commits intomasterfrom
fulcanellee merged 3 commits intomasterfrom
Conversation
fulcanellee
requested review from
SiebenSieben,
hextion and
reme3d2y
as code owners
🦋 Changeset detectedLatest commit: 462bf2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Собрана новая демка. |
fulcanellee
force-pushed
the
feat/filter-tag_themezation
branch
from
a81c6c4 to
35786e3
Compare
Collaborator
|
Собрана новая демка. |
Oladii
changed the title
dedanu
approved these changes
Oct 17, 2024
Ackedze
approved these changes
Oct 17, 2024
ouchnomad
approved these changes
Oct 17, 2024
Oladii
reviewed
Oct 17, 2024
Contributor
There was a problem hiding this comment.
думаю стоит 28 захардкодить, так как это не совсем легальный гэп чтобы выносить его в переменные. В макете используется конструкция из суммы 2х гэпов 24 и 4 которые относятся к разным деталям тэга, но в коде исторически это один отступ.
Oladii
approved these changes
Oct 17, 2024
Collaborator
|
Собрана новая демка. |
NikitaRodyukov
approved these changes
Oct 22, 2024
hextion
approved these changes
Oct 22, 2024
reme3d2y
approved these changes
Oct 23, 2024
Contributor
|
@Oladii тут меняются размеры компонента, потенциально это может поломать где-нибудь верстку. Мы считаем это миноркой? |
SiebenSieben
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.moscow.alfaintra.net/browse/DS-7037
Изменены отступы в tag и filter-tag