Skip to content

docs: добавил ссылки для компонентов в figma #202

Merged
SiebenSieben merged 3 commits intomasterfrom
docs/figma-links
Sep 1, 2022
Merged

docs: добавил ссылки для компонентов в figma #202
SiebenSieben merged 3 commits intomasterfrom
docs/figma-links

Conversation

@EGNKupava
Copy link
Copy Markdown
Contributor

@EGNKupava EGNKupava commented Aug 18, 2022 •
edited
Loading

📈 Добавил ссылки в figma для компонентов в соответствии с таблицей
😞 Ссылки есть не для всех копонентов

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2903443536

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.78%
Totals Coverage Status
Change from base Build 2888440380: 0.0%
Covered Lines: 5801
Relevant Lines: 6525
💛 - Coveralls

@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Aug 18, 2022

Собрана новая демка.

@SiebenSieben
Copy link
Copy Markdown
Contributor

SiebenSieben commented Aug 19, 2022

Для каких нет ссылок?

@EGNKupava
Copy link
Copy Markdown
Contributor Author

EGNKupava commented Aug 19, 2022

Для каких нет ссылок?

AmountInput
Backdrop
BankCard
BaseModal
CalendarInput
CalendarWithSkeleton
CardImage
CDNIcon
Chart
CodeInput
Collapse
Divider
Drawer
FormControl
Gallery
Grid
IntlPhoneInput
KeyboardFocusable
ListHeader
MaskedInput
Mq
NotificationManager
Pagination
PasswordInput
PhoneInput
Popover
Portal
PureInput
Skeleton
Space
Stack
Table
ToastPlate
withSuffix

@SiebenSieben SiebenSieben linked an issue Aug 19, 2022 that may be closed by this pull request
Обновить ссылки на дизайн систему #55
Closed
@SiebenSieben SiebenSieben requested a review from Oladii August 22, 2022 08:58
Oladii
Oladii requested changes Aug 22, 2022
View reviewed changes
Comment thread packages/list/src/docs/description.mdx
## Использование в Webview

[Описание компонента для Webview](https://www.figma.com/file/sg7PXgmiiFjLXC6YJfoCKD/%D0%A0%D0%B0%D0%B7%D0%B1%D0%BE%D1%80-%D1%81%D1%86%D0%B5%D0%BD%D0%B0%D1%80%D0%B8%D0%B5%D0%B2-%D0%BF%D1%80%D0%B5%D0%B4%D0%BE%D0%B4%D0%BE%D0%B1%D1%80%D0%B5%D0%BD%D0%BD%D1%8B%D1%85-%D0%BA%D0%B0%D1%80%D1%82-%D0%92%D0%BE%D0%BB%D0%B3%D0%B0?node-id=2778%3A1002)

Copy link
Copy Markdown
Contributor

@Oladii Oladii Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно поидее заменить ссылку на это
https://www.figma.com/file/2qkmYHFmV1rEmJyb6cEsW9/Web-%3A%3A-Mobile-Components?node-id=1153%3A300671

Comment thread packages/cdn-icon/src/docs/Component.stories.mdx
package='@alfalab/core-components/cdn-icon'
stage={2}
design='https://www.figma.com/file/QoGuPDB1hAMoMMqsQQ4Mx7lB/?node-id=3882%3A144'
/>
Copy link
Copy Markdown
Contributor

@Oladii Oladii Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.figma.com/file/ZcdUPebEhHfSZ91zgmv2cK/Icons?node-id=7392%3A10

Copy link
Copy Markdown
Contributor

@Oladii Oladii Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На компоненты Alert и Plate над вот эту ссылку прицепить (только залили в фигму)
https://www.figma.com/file/cdNnkh2QdxuvYLrBm4cubM/Web-%3A%3A-Core-Default-Components?node-id=60647%3A87135

@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Aug 22, 2022

Собрана новая демка.

Oladii
Oladii approved these changes Aug 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Oladii Oladii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для кейсов где нет ссылок будем их добавлять по мере причесывания демок.

@SiebenSieben SiebenSieben merged commit 3410ffd into master Sep 1, 2022
@SiebenSieben SiebenSieben deleted the docs/figma-links branch September 1, 2022 10:11
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Sep 1, 2022

🎉 This PR is included in version 30.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@Oladii Oladii Oladii approved these changes

@churicheva-v churicheva-v churicheva-v approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y

@v-gevak v-gevak Awaiting requested review from v-gevak

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Обновить ссылки на дизайн систему

6 participants

@EGNKupava @coveralls @core-ds-bot @SiebenSieben @Oladii @churicheva-v