Conversation
dHIM24
requested review from
SiebenSieben,
fulcanellee and
hextion
as code owners
🦋 Changeset detectedLatest commit: ea3e632 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dHIM24
changed the title
Coverage Report for CI Build 26284586951Coverage remained the same at 82.241%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Demo build (default) |
Contributor
Demo build (alfasans) |
hextion
requested changes
May 21, 2026
| } | ||
|
|
||
| .component .slider { | ||
| --slider-pips-offset-inline: 0; |
Collaborator
There was a problem hiding this comment.
все переменные должны быть в :root
| --slider-clickable-area-half-size: calc(var(--slider-clickable-area-size) / 2); | ||
| --slider-origin-width: calc(100% - 16px); | ||
| --slider-origin-right: 8px; | ||
| --slider-pips-offset-top: var(--gap-6); |
Collaborator
There was a problem hiding this comment.
для чего переменные заведены?
hextion
requested changes
May 21, 2026
| --- | ||
| '@alfalab/core-components-slider': patch | ||
| '@alfalab/core-components-slider-input': patch | ||
| '@alfalab/core-components': patch |
Collaborator
There was a problem hiding this comment.
либо исключить этот пункт, либо дописать ##### Slider, SliderInput ниже
fulcanellee
approved these changes
May 21, 2026
Contributor
|
сломался дефолт: В ветке точка сдвинулась |
dHIM24
force-pushed
the
DS-17047
branch
2 times, most recently
from
2dd5353 to
7d5586c
Compare
hextion
approved these changes
May 22, 2026
Oladii
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min/max) под слайдером.Чек лист
Если есть визуальные изменения
Slider
SliderInput [others-themes]
SliderInput [site-theme]