Skip to content

feat(pure-cell): replace flex gap to margins for correct work on ios13#452

Merged
SiebenSieben merged 1 commit intomasterfrom
fix/pure-cell-margins
Jan 16, 2023
Merged

feat(pure-cell): replace flex gap to margins for correct work on ios13#452
SiebenSieben merged 1 commit intomasterfrom
fix/pure-cell-margins

Conversation

@Romkaf
Copy link
Contributor

@Romkaf Romkaf commented Jan 12, 2023

Опишите проблему

Не применяются отступы(gap) для чалдов flex контейнера компонента PureCell на ios13 и ниже.
https://caniuse.com/?search=flex-gap

Шаги для воспроизведения

  1. Открыть https://core-ds.github.io/core-components/master/?path=/docs/components-cells-purecell--pure-cell
    на ios13

Ожидаемое поведение

Отступы остаются на ios13 и ниже.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023

⚠️ No Changeset found

Latest commit: 02339b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3901707307

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.686%

Totals Coverage Status
Change from base Build 3880599043: 0.0%
Covered Lines: 7309
Relevant Lines: 8259

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak
Copy link
Contributor

v-gevak commented Jan 13, 2023

А точно ли оно нужно @SiebenSieben? Около 1% сидят на 13 iOS

@Romkaf
Copy link
Contributor Author

Romkaf commented Jan 13, 2023

По официальной статистики пользаков АО 12 - 22.4K, 13 - 13.8K
даже если это 1%, нужно сделать по уму

@Romkaf
Copy link
Contributor Author

Romkaf commented Jan 13, 2023

3,38% по последней инфо)

@v-gevak
Copy link
Contributor

v-gevak commented Jan 13, 2023

По официальной статистики пользаков АО 12 - 22.4K, 13 - 13.8K даже если это 1%, нужно сделать по уму

Жеска

@SiebenSieben SiebenSieben merged commit 91724f2 into master Jan 16, 2023
@SiebenSieben SiebenSieben deleted the fix/pure-cell-margins branch January 16, 2023 09:12
v-gevak added a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants