Skip to content

feat(input-autocomplete): add new component InputAutocompleteMobile#96

Merged
v-gevak merged 1 commit intomasterfrom
feat/input-autocomplete-mobile
Jun 20, 2022
Merged

feat(input-autocomplete): add new component InputAutocompleteMobile#96
v-gevak merged 1 commit intomasterfrom
feat/input-autocomplete-mobile

Conversation

@v-gevak
Copy link
Copy Markdown
Contributor

@v-gevak v-gevak commented Jun 15, 2022 •
edited
Loading

Новый компонент InputAutocompleteMobile

Чек лист

  • Написать тесты

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2528667884

  • 91 of 97 (93.81%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.4%) to 84.816%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bottom-sheet/src/component.tsx 3 4 75.0%
packages/input-autocomplete/src/Component.mobile.tsx 53 58 91.38%
Totals Coverage Status
Change from base Build 2528399986: 2.4%
Covered Lines: 5432
Relevant Lines: 5936
💛 - Coveralls

@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 15, 2022

Собрана новая демка.

@v-gevak v-gevak force-pushed the feat/input-autocomplete-mobile branch from be2504c to e7999f5 Compare June 15, 2022 12:12
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 15, 2022

Собрана новая демка.

@v-gevak v-gevak force-pushed the feat/input-autocomplete-mobile branch from e7999f5 to 2d294c5 Compare June 15, 2022 13:07
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 15, 2022

Собрана новая демка.

@v-gevak v-gevak force-pushed the feat/input-autocomplete-mobile branch from 2d294c5 to f106504 Compare June 16, 2022 10:22
@v-gevak v-gevak marked this pull request as ready for review June 16, 2022 10:28
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 16, 2022

Собрана новая демка.

v-gevak
v-gevak commented Jun 16, 2022
View reviewed changes
packages/bottom-sheet/src/component.tsx Outdated
>
<div
{...containerProps}
className={cn(styles.scrollableContainer, containerClassName, {
Copy link
Copy Markdown
Contributor Author

@v-gevak v-gevak Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавить containerProps.className, containerClassName задепрекейтить

@Romkaf Romkaf self-requested a review June 20, 2022 08:50
@v-gevak v-gevak force-pushed the feat/input-autocomplete-mobile branch from f106504 to c0846c5 Compare June 20, 2022 10:28
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 20, 2022

Собрана новая демка.

@v-gevak v-gevak force-pushed the feat/input-autocomplete-mobile branch from c0846c5 to 8492c74 Compare June 20, 2022 11:38
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 20, 2022

Собрана новая демка.

@v-gevak v-gevak merged commit a0e9f95 into master Jun 20, 2022
@v-gevak v-gevak deleted the feat/input-autocomplete-mobile branch June 20, 2022 12:19
core-ds-bot pushed a commit that referenced this pull request Jun 20, 2022
@semantic-release-bot
chore(release): 27.8.0 [skip ci]
059c7b1 
# [27.8.0](v27.7.0...v27.8.0) (2022-06-20)

### Bug Fixes

* fixed launch storybook in IE ([#52](#52)) ([379528b](379528b))

### Features

* **input-autocomplete:** add new component InputAutocompleteMobile ([#96](#96)) ([a0e9f95](a0e9f95))
@core-ds-bot
Copy link
Copy Markdown
Collaborator

core-ds-bot commented Jun 20, 2022

🎉 This PR is included in version 27.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyushev vyushev vyushev approved these changes

@Romkaf Romkaf Romkaf approved these changes

@EGNKupava EGNKupava EGNKupava approved these changes

@Oladii Oladii Oladii approved these changes

@churicheva-v churicheva-v churicheva-v approved these changes

@SiebenSieben SiebenSieben Awaiting requested review from SiebenSieben SiebenSieben is a code owner

+1 more reviewer

@reme3d2y reme3d2y reme3d2y approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@v-gevak @coveralls @core-ds-bot @reme3d2y @vyushev @Romkaf @EGNKupava @Oladii @churicheva-v