fix: preserve panchayat_boundaries style#352
Open
Athina09 wants to merge 1 commit intocore-stack-org:developmentfrom
Open
fix: preserve panchayat_boundaries style#352Athina09 wants to merge 1 commit intocore-stack-org:developmentfrom
Athina09 wants to merge 1 commit intocore-stack-org:developmentfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a style override bug in
getVectorLayerswhere the custompanchayat_boundariesstyle was being immediately replaced by the generic default style.Problem
In
src/actions/getVectorLayers.js, the code first applies:PanchayatBoundariesStylewhenlayer_store === "panchayat_boundaries"But right after that, it always applies a generic style:
This unconditional second
setStyle(...)overwrote the panchayat-specific style.Fix
Updated style assignment logic to be conditional:
layer_store === "panchayat_boundaries", keepPanchayatBoundariesStyle.Impact
File changed
src/actions/getVectorLayers.js