Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FFT kernel test file and standardizes command-line argument naming across the test suite by renaming a compiler pass flag from --promote-func-arg-to-const to --promote-input-arg-to-const.
Changes:
- Added a complete FFT kernel test file with MLIR compilation and mapping verification
- Updated compiler pass flag name to use consistent
input-argterminology - Updated CGRA-Bench submodule reference
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/e2e/fft/fft_kernel.mlir | Adds new comprehensive FFT kernel test with compilation pipeline, mapping verification, and generated code checks |
| test/e2e/bicg/bicg_int_kernel.mlir | Updates compiler pass flag from --promote-func-arg-to-const to --promote-input-arg-to-const |
| test/benchmark/CGRA-Bench | Updates submodule commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tancheng
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.