fw/drivers/sf32lb52: f32lb52 Solve the boot abnormality caused by the rng driver#121
Closed
w200024212 wants to merge 1 commit intocoredevices:mainfrom
Closed
fw/drivers/sf32lb52: f32lb52 Solve the boot abnormality caused by the rng driver#121w200024212 wants to merge 1 commit intocoredevices:mainfrom
w200024212 wants to merge 1 commit intocoredevices:mainfrom
Conversation
jwise
approved these changes
Jul 17, 2025
Contributor
jwise
left a comment
jwise
left a comment
There was a problem hiding this comment.
LGTM, though it would be nice to have a short // comment in there saying why this always needs to be called in is_seed mode (it already tripped us up once... probably if we continue to use this API it might trip us up again :) )
Member
|
@w200024212 please add comment and we’ll then merge |
Contributor
Author
ok! |
… rng driver rng driver parameter is_seed need set to 1; Signed-off-by: Jerrywang <w200024212@163.com>
Contributor
Author
|
Before generating random numbers, it is necessary to ensure that the seed is valid.So, I made some adjustments to the code. |
Member
|
merged here 44572c6 also refactored code as I was having difficulties in following the logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rng driver parameter is_seed need set to 1;