fix(kubernetes): look up headless_with_selector metric by label in e2e test#174
Merged
yongtang merged 1 commit intoMar 24, 2026
Conversation
…e test cluster_ip is now also recorded by the dns_programming_duration metric (coredns/coredns#7951), so Metric[0] is no longer reliably the headless_with_selector series. Use a label-based lookup instead. Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion fix for coredns/coredns#7951, which extends
coredns_kubernetes_dns_programming_duration_secondsto recordcluster_ipservices in addition toheadless_with_selector.Problem:
TestDNSProgrammingLatencyEndpointsselected the histogram to check viaMetric[0]. Before #7951, onlyheadless_with_selectorwas ever emitted, soMetric[0]was always that series. After #7951,cluster_ipis also emitted and sorts alphabetically beforeheadless_with_selector, soMetric[0]changed, causing the expected delta check to fail.Fix: Extract a
metricByServiceKindhelper that finds the correct*dto.Metricby itsservice_kindlabel value, and use it to selectheadless_with_selectorexplicitly in both the base and final scrape comparisons.