fix: isMatchDFA concurrent safety — prefilter rejection only (#137)#145
Merged
Conversation
isMatchDFA prefilter candidate loop called e.dfa.SearchAtAnchored concurrently from RunParallel — shared lazy DFA NOT thread-safe. On ARM64 without SIMD: cache corruption, 1.7GB allocs, 1s+ per op. Fix: prefilter for fast rejection only, DFA.IsMatch for verification. Added TestConcurrentCaseInsensitivePrefilter (8 goroutines x 100 iters). Reported by @tjbrains on M2 Max.
71312bd to
a92ec46
Compare
Benchmark ComparisonComparing Summary:
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isMatchDFAprefilter candidate loop callede.dfa.SearchAtAnchoredconcurrently fromRunParallel. Shared lazy DFA is NOT thread-safe for concurrent lazy state construction. On ARM64 without SIMD prefilters, every candidate hit DFA → cache corruption → 1.7GB allocs, 1s+ per op on M2 Max.Fix: prefilter used for fast rejection only (one
Findcall). Verification falls through toDFA.IsMatch(read-mostly when cache warm).Test:
TestConcurrentCaseInsensitivePrefilter— 8 goroutines × 100 iterations, match + no-match paths.Reported by @tjbrains on Apple M2 Max (#137).
Test plan