Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

Add cloudformation helper scripts and a few improvements#1

Merged
colhom merged 1 commit intocoreos:masterfrom
mumoshu:master
Nov 15, 2016
Merged

Add cloudformation helper scripts and a few improvements#1
colhom merged 1 commit intocoreos:masterfrom
mumoshu:master

Conversation

@mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Nov 15, 2016

  • Uninstall py-pip without creating unnecessary docker image layers. py-pip is not required at runtime.
  • Add cloudformation helper scripts consists of well-known cfn-init, cfn-signal, etc to be used for deepder integration with cloudformation. To be used for e.g. Proposal: Clouformation wait for signal  kubernetes-retired/kube-aws#49.
  • apk add --no-cache for not populating /var/apk/cache to reduce image size

ref kubernetes-retired/kube-aws#55

succeed to kubernetes-retired/kube-aws#56

@mumoshu
Copy link
Contributor Author

mumoshu commented Nov 15, 2016

Btw this change adds only less than 2%(0.4 MB) of size to the docker image!
Thus, I assume there's no issue regarding its size.
kubernetes-retired/kube-aws#55 (comment)

* Uninstall py-pip without creating unnecessary docker image layers. py-pip is not required at runtime.
* Add cloudformation helper scripts consists of well-known cfn-init, cfn-signal, etc to be used for deepder integration with cloudformation. To be used for e.g. kubernetes-retired/kube-aws#49.
* `apk add --no-cache` for not populating /var/apk/cache to reduce image size

ref kubernetes-retired/kube-aws#55

succeed to kubernetes-retired/kube-aws#56
@colhom
Copy link
Contributor

colhom commented Nov 15, 2016

LGTM

I'm going to say the && of expressions is fundamentally better for our use case now than separate RUN blocks (we're not interested the intermediary build layers in all likelihood)

@colhom colhom merged commit 8b19a41 into coreos:master Nov 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants