This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Merged
Conversation
If we're going to lock awscli and s3cmd, we might as well version lock aws-cfn-bootstrap.
Contributor
|
@pieterlange can we stuff the contents of that tarball in this repo and install it that way? I'd rather not involve dangling pointers to s3 if possible. |
Contributor
|
@pieterlange not a python person- excuse the ignorance. I see that bucket referenced in many places- can we consider it reliable and canonical going forward? If so, we can keep the s3 reference. If there's a chance it goes stale/references change, I feel we should stuff it in the repo here. |
Contributor
Author
|
Not a python person either, but i think amazon will keep this bucket around - they have for years. No need to vendor the file. |
Contributor
|
Alrighty then- LGTM it is! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're going to lock awscli and s3cmd, we might as well version lock aws-cfn-bootstrap.