efi: Respect SOURCE_DATE_EPOCH for reproducible builds#1093
Merged
cgwalters merged 1 commit intocoreos:mainfrom Apr 29, 2026
Merged
efi: Respect SOURCE_DATE_EPOCH for reproducible builds#1093cgwalters merged 1 commit intocoreos:mainfrom
cgwalters merged 1 commit intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility function, get_metadata_timestamp, which provides support for the SOURCE_DATE_EPOCH environment variable to ensure reproducible builds. This function is integrated into src/efi.rs, replacing manual timestamp generation. A review comment correctly identified that from_timestamp_secs is not a valid method in the chrono crate and suggested using from_timestamp instead to fix the potential compilation error.
Johan-Liebert1
force-pushed
the
epoch-env
branch
from
661fd0c to
e6405c7
Compare
If SOURCE_DATE_EPOCH env is set, use it for EFI metadata timestamp, else fallback to SystemTime::now() The BIOS component derives its timestamp from RPM build times so it is already deterministic Fixes: coreos#1075 Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
epoch-env
branch
from
e6405c7 to
e9fc003
Compare
cgwalters
approved these changes
Apr 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If SOURCE_DATE_EPOCH env is set, use it for EFI metadata timestamp, else fallback to SystemTime::now()
The BIOS component derives its timestamp from RPM build times so it is already deterministic
Fixes: #1075